Refactor NO_TICKET Various improvements #21
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| navigationActionStack.arrangedSubviews + | ||
| leadingPageActionStack.arrangedSubviews + | ||
| pageActionStack.arrangedSubviews | ||
| browserActionStack.arrangedSubviews |
There was a problem hiding this comment.
Duplicate browserActionStack causes missing alpha animation
Medium Severity
The stacks variable includes browserActionStack.arrangedSubviews twice but omits trailingPageActionStack.arrangedSubviews. This appears to be a copy-paste error during the rename from pageActionStack to trailingPageActionStack. As a result, the trailing page action buttons won't have their alpha set to 1.0 during toolbar animations, leaving them invisible after animation completes.
|
|
||
| // Page action spacing | ||
| let hasPageActions = !pageActionStack.arrangedSubviews.isEmpty | ||
| let hasPageActions = !leadingPageActionStack.arrangedSubviews.isEmpty |
There was a problem hiding this comment.
Wrong stack checked for divider width calculation
Medium Severity
The hasPageActions check was changed from the renamed trailingPageActionStack to leadingPageActionStack. The locationDividerView is positioned between locationView and trailingPageActionStack, so the divider width should be set based on whether there are trailing page actions, not leading ones. This may cause the divider to show/hide incorrectly.
| insertSubview(rightSkeletonAddressBar, aboveSubview: toolbar) | ||
|
|
||
| toolbar.leadingAnchor.constraint(equalTo: leftSkeletonAddressBar.trailingAnchor).isActive = true | ||
| toolbar.leadingAnchor.constraint(equalTo: rightSkeletonAddressBar.trailingAnchor).isActive = true |
There was a problem hiding this comment.
Toolbar leading constraint uses wrong skeleton anchor
High Severity
The toolbar's leadingAnchor constraint was changed from leftSkeletonAddressBar.trailingAnchor to rightSkeletonAddressBar.trailingAnchor. Since the right skeleton is positioned outside the container's trailing edge, this constraint places the toolbar's leading edge beyond the right skeleton, creating an impossible or broken layout with the toolbar potentially having zero or negative width.
Benchmark PR from qodo-benchmark#228
Note
Improves testability and clarifies toolbar layout while adjusting constraints.
Browser.statusBarOverlay,Browser.headerContainer,Browser.overKeyboardContainer,Browser.bottomContainer,Browser.bottomContentStackView, andBrowser.contentContainer, and assigns them inBrowserViewController.pageActionStacktotrailingPageActionStackand updates all related constraints/usages. Adjusts page-action divider width logic to depend onleadingPageActionStackpresence. Keeps stacks hidden based onscrollAlpha.shoudShowKeyboard→shouldShowKeyboardand updates Redux dispatch condition. Tweaks toolbar/skeleton address bar constraints and simplifies skeleton layout setup when swiping tabs is enabled.Written by Cursor Bugbot for commit ce7cd22. Configure here.